Change in coreboot[master]: 3rdparty/fsp: Set back commit to working version of the FSP.
Christian Walter has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP. ......................................................................
3rdparty/fsp: Set back commit to working version of the FSP.
With CB 37564 a regression has been introduced to CFL platforms, such that the FSP-M fails/is broken. THis commit sets the commit to checkout in the submodule fsp back to a working version.
Change-Id: I8eac551211559962fc60e7edd46ff118d7bde830 Signed-off-by: Christian Walter christian.walter@9elements.com --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/37669/1
diff --git a/3rdparty/fsp b/3rdparty/fsp index 0bc2b07..573bd5d 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 0bc2b07eab29a8a75cd084963c285ee5434e6666 +Subproject commit 573bd5d6861376c8b4947d177dfe70592ff80fc2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP. ......................................................................
Patch Set 1:
+Subrata so he's up to date on the latest developments in this area (although the Real Fix[tm] needs to come from Intel)
Hello Subrata Banik, Angel Pons, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37669
to look at the new patch set (#2).
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP. ......................................................................
3rdparty/fsp: Set back commit to working version of the FSP.
With CB 37564 a regression has been introduced to CFL platforms, such that the FSP-M fails/is broken. THis commit sets the commit to checkout in the submodule fsp back to a working version.
Change-Id: I8eac551211559962fc60e7edd46ff118d7bde830 Signed-off-by: Christian Walter christian.walter@9elements.com --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/37669/2
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP. ......................................................................
Patch Set 2: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@7 PS2, Line 7: working version One space.
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@9 PS2, Line 9: CB 37564 Please add the commit message summary in ().
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@10 PS2, Line 10: THis This
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@11 PS2, Line 11: fsp FSP
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP. ......................................................................
Patch Set 2:
+Nathaniel because he pushed the Coffee Lake FSP 7.0.68.40 [1] that is causing issues. Maybe he knows if FSP 7.0.68.41 has a fix for that bug?
[1]: https://github.com/IntelFsp/FSP/commit/f3ecfc496e9c07b553582197b5086cfe9948b...
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP. ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@7 PS2, Line 7: . commit summaries do not end with a period
Hello Angel Pons, Subrata Banik, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37669
to look at the new patch set (#3).
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP ......................................................................
3rdparty/fsp: Set back commit to working version of the FSP
With CB 37564 (3rdparts/fsp: Update fsp submodule) a regression has been introduced to CFL platforms, such that the FSP-M fails/is broken. This commit sets the commit to checkout in the submodule FSP back to a working version.
Change-Id: I8eac551211559962fc60e7edd46ff118d7bde830 Signed-off-by: Christian Walter christian.walter@9elements.com --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/37669/3
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP ......................................................................
Patch Set 3:
(5 comments)
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@7 PS2, Line 7: working version
One space.
Ack
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@7 PS2, Line 7: .
commit summaries do not end with a period
Ack
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@9 PS2, Line 9: CB 37564
Please add the commit message summary in ().
Ack
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@10 PS2, Line 10: THis
This
Ack
https://review.coreboot.org/c/coreboot/+/37669/2//COMMIT_MSG@11 PS2, Line 11: fsp
FSP
Ack
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP ......................................................................
Patch Set 3: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP ......................................................................
Patch Set 3: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
Juuust a minor thing.
https://review.coreboot.org/c/coreboot/+/37669/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37669/3//COMMIT_MSG@9 PS3, Line 9: CB 37564 Nit: Add a colon to CB:37564
Hello Patrick Rudolph, Angel Pons, Subrata Banik, Paul Menzel, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37669
to look at the new patch set (#4).
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP ......................................................................
3rdparty/fsp: Set back commit to working version of the FSP
With CB:37564 (3rdparts/fsp: Update fsp submodule) a regression has been introduced to CFL platforms, such that the FSP-M fails/is broken. This commit sets the commit to checkout in the submodule FSP back to a working version.
Change-Id: I8eac551211559962fc60e7edd46ff118d7bde830 Signed-off-by: Christian Walter christian.walter@9elements.com --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/69/37669/4
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37669/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37669/3//COMMIT_MSG@9 PS3, Line 9: CB 37564
Nit: Add a colon to CB:37564
Ack
Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP ......................................................................
Patch Set 4: Code-Review+1
Mimoja has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP ......................................................................
Patch Set 4:
Thank you for going the extra mile.
Patrick Rudolph has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37669 )
Change subject: 3rdparty/fsp: Set back commit to working version of the FSP ......................................................................
3rdparty/fsp: Set back commit to working version of the FSP
With CB:37564 (3rdparts/fsp: Update fsp submodule) a regression has been introduced to CFL platforms, such that the FSP-M fails/is broken. This commit sets the commit to checkout in the submodule FSP back to a working version.
Change-Id: I8eac551211559962fc60e7edd46ff118d7bde830 Signed-off-by: Christian Walter christian.walter@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37669 Reviewed-by: Mimoja coreboot@mimoja.de Reviewed-by: Patrick Rudolph siro@das-labor.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M 3rdparty/fsp 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Patrick Rudolph: Looks good to me, approved Mimoja: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/3rdparty/fsp b/3rdparty/fsp index 0bc2b07..9e53d77 160000 --- a/3rdparty/fsp +++ b/3rdparty/fsp @@ -1 +1 @@ -Subproject commit 0bc2b07eab29a8a75cd084963c285ee5434e6666 +Subproject commit 9e53d779eb34e944f9b3386ad6a9df80f710bddd
-
Angel Pons (Code Review) -
Christian Walter (Code Review)
-
Mimoja (Code Review)
-
Nico Huber (Code Review)
-
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)