Attention is currently required from: Benjamin Doron, Dinesh Gehlot, Kane Chen, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Paul Menzel, Sowmya Aralguppe, Subrata Banik.
Angel Pons has posted comments on this change by Sowmya Aralguppe. ( https://review.coreboot.org/c/coreboot/+/82136?usp=email )
Change subject: mb/google/brox: Fix CPU crashlog device MMIO memory access
......................................................................
Patch Set 10: -Code-Review
(1 comment)
File src/soc/intel/alderlake/crashlog.c:
https://review.coreboot.org/c/coreboot/+/82136/comment/2d11a895_2d4f6b5d?usp... :
PS10, Line 205: &
Why bitwise `&`? Did you mean to use logical `&&` operator?
Good point. The code says "if `dw1` and `dw0` don't have any one-bits in common", which is rather odd.
As per the surrounding code, looks like this is a 64-bit register (a memory address?), and a zero address would be invalid. If this is correct, then the check should be:
```suggestion
if (!dw1 && !dw0) {
```
This would be equivalent, but I feel it's harder to understand so I prefer the former:
```
if (!(dw1 | dw0)) {
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82136?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I262254ee8d0eb91efcb3e748d121e13c31e66251
Gerrit-Change-Number: 82136
Gerrit-PatchSet: 10
Gerrit-Owner: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-CC: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Sowmya Aralguppe
sowmya.aralguppe@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 30 May 2024 18:46:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com