Peichao Li has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
mb/mainboard/hatch: support elan touchpad for Akemi
BUG=b:141519690 TEST=build bios and verify elan touchpad work fine
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6cc5b780ffcee24f1f2a04e88c30628ceb5904e8 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/35551/1
diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index 88d33e7..c34168a 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -64,7 +64,7 @@ chip drivers/i2c/generic register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D21_IRQ)" + register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_A21_IRQ)" register "wake" = "GPE0_DW0_21" register "probed" = "1" device i2c 15 on end
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35551/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35551/1//COMMIT_MSG@7 PS1, Line 7: support elan touchpad for Please update the commit message to reflect what really the change is.
https://review.coreboot.org/c/coreboot/+/35551/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35551/1/src/mainboard/google/hatch/... PS1, Line 67: ACPI_IRQ_EDGE_LOW This should be ACPI_IRQ_WAKE_EDGE_LOW if you have to support wake from touchpad.
https://review.coreboot.org/c/coreboot/+/35551/1/src/mainboard/google/hatch/... PS1, Line 75: ACPI_IRQ_EDGE_LOW Same here.
Hello Tim Wawrzynczak, Shelley Chen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35551
to look at the new patch set (#2).
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
mb/mainboard/hatch: support elan touchpad for Akemi
Modify IRQ pin from D21 to A21 and support wake up from touchpad
BUG=b:141519690 TEST=build bios and verify elan touchpad work fine
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6cc5b780ffcee24f1f2a04e88c30628ceb5904e8 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/35551/2
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35551/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35551/1//COMMIT_MSG@7 PS1, Line 7: support elan touchpad for
Please update the commit message to reflect what really the change is.
Done
https://review.coreboot.org/c/coreboot/+/35551/1/src/mainboard/google/hatch/... File src/mainboard/google/hatch/variants/akemi/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/35551/1/src/mainboard/google/hatch/... PS1, Line 67: ACPI_IRQ_EDGE_LOW
This should be ACPI_IRQ_WAKE_EDGE_LOW if you have to support wake from touchpad.
Done
https://review.coreboot.org/c/coreboot/+/35551/1/src/mainboard/google/hatch/... PS1, Line 75: ACPI_IRQ_EDGE_LOW
Same here.
Done
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
Patch Set 2: Code-Review+1
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35551/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35551/2//COMMIT_MSG@9 PS2, Line 9: wake up wake-up
https://review.coreboot.org/c/coreboot/+/35551/2//COMMIT_MSG@10 PS2, Line 10: Is that information from the schematics or the datasheet?
https://review.coreboot.org/c/coreboot/+/35551/2//COMMIT_MSG@12 PS2, Line 12: work works
Hello Philip Chen, Tim Wawrzynczak, Shelley Chen, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35551
to look at the new patch set (#3).
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
mb/mainboard/hatch: support elan touchpad for Akemi
Modify IRQ pin from D21 to A21 and support wake-up from touchpad
BUG=b:141519690 TEST=build bios and verify elan touchpad works fine
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6cc5b780ffcee24f1f2a04e88c30628ceb5904e8 --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/35551/3
Peichao Li has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35551/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35551/2//COMMIT_MSG@9 PS2, Line 9: wake up
wake-up
Done
https://review.coreboot.org/c/coreboot/+/35551/2//COMMIT_MSG@10 PS2, Line 10:
Is that information from the schematics or the datasheet?
Dear Paul, I have verify multi-touchpad: elan and Synaptics, which working properly. Thanks a lot!
https://review.coreboot.org/c/coreboot/+/35551/2//COMMIT_MSG@12 PS2, Line 12: work
works
Done
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
Patch Set 3: Code-Review+2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35551/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35551/2//COMMIT_MSG@10 PS2, Line 10:
Dear Paul, I have verify multi-touchpad: elan and Synaptics, which working properly. […]
Ack
Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35551 )
Change subject: mb/mainboard/hatch: support elan touchpad for Akemi ......................................................................
mb/mainboard/hatch: support elan touchpad for Akemi
Modify IRQ pin from D21 to A21 and support wake-up from touchpad
BUG=b:141519690 TEST=build bios and verify elan touchpad works fine
Signed-off-by: Peichao Wang peichao.wang@bitland.corp-partner.google.com Change-Id: I6cc5b780ffcee24f1f2a04e88c30628ceb5904e8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/35551 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Martin Roth martinroth@google.com Reviewed-by: Shelley Chen shchen@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/akemi/overridetree.cb 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Shelley Chen: Looks good to me, but someone else must approve Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/akemi/overridetree.cb b/src/mainboard/google/hatch/variants/akemi/overridetree.cb index 88d33e7..5ba8531 100644 --- a/src/mainboard/google/hatch/variants/akemi/overridetree.cb +++ b/src/mainboard/google/hatch/variants/akemi/overridetree.cb @@ -64,7 +64,7 @@ chip drivers/i2c/generic register "hid" = ""ELAN0000"" register "desc" = ""ELAN Touchpad"" - register "irq" = "ACPI_IRQ_EDGE_LOW(GPP_D21_IRQ)" + register "irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_A21_IRQ)" register "wake" = "GPE0_DW0_21" register "probed" = "1" device i2c 15 on end @@ -72,7 +72,7 @@ chip drivers/i2c/hid register "generic.hid" = ""PNP0C50"" register "generic.desc" = ""Synaptics Touchpad"" - register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_A21_IRQ)" + register "generic.irq" = "ACPI_IRQ_WAKE_EDGE_LOW(GPP_A21_IRQ)" register "generic.wake" = "GPE0_DW0_21" register "generic.probed" = "1" register "hid_desc_reg_offset" = "0x20"
-
Furquan Shaikh (Code Review) -
Martin Roth (Code Review)
-
Paul Menzel (Code Review)
-
Peichao Li (Code Review)
-
Shelley Chen (Code Review)
-
Tim Wawrzynczak (Code Review)