Attention is currently required from: Jonathan Zhang, Christian Walter, Arthur Heymans, Tim Chu, Shelly Chang.
Hello Shelly Chang,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/69146
to review the following change.
Change subject: mb/ocp/deltalake: Add EWL Hob processing for MRC error ......................................................................
mb/ocp/deltalake: Add EWL Hob processing for MRC error
Override the weak function mainboard_ewl_check() and select OCP_EWL. The Intel FSP needs to disble promote MRC Warnings otherwise FSP won't return after MRC error.
Change-Id: I4419ef43815f8181af89c49514a69bdb29858c13 Signed-off-by: Shelly Chang Shelly_Chang@wiwynn.com Signed-off-by: Johnny Lin johnny_lin@wiwynn.com --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/romstage.c 2 files changed, 22 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/69146/1
diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig index dbf4a2e..654a816 100644 --- a/src/mainboard/ocp/deltalake/Kconfig +++ b/src/mainboard/ocp/deltalake/Kconfig @@ -11,6 +11,7 @@ select IPMI_KCS select IPMI_KCS_ROMSTAGE select OCP_DMI + select OCP_EWL select VPD select VPD_SMBIOS_VERSION select IPMI_OCP diff --git a/src/mainboard/ocp/deltalake/romstage.c b/src/mainboard/ocp/deltalake/romstage.c index 2efed1c..4b967bf 100644 --- a/src/mainboard/ocp/deltalake/romstage.c +++ b/src/mainboard/ocp/deltalake/romstage.c @@ -4,6 +4,7 @@ #include <console/uart.h> #include <drivers/ipmi/ipmi_if.h> #include <drivers/ipmi/ocp/ipmi_ocp.h> +#include <drivers/ocp/ewl/ocp_ewl.h> #include <drivers/vpd/vpd.h> #include <fsp/api.h> #include <FspmUpd.h> @@ -14,6 +15,11 @@ #include "ipmi.h" #include "vpd.h"
+void mainboard_ewl_check(void) +{ + get_ewl(); +} + /* Convert the vpd integer to the DDR frenquency limit enum */ static enum ddr_freq_limit ddr_freq_limit(int num) {