[M] Change in coreboot[master]: soc/amd/common/xhci: Add support for logging XHCI wake events
Attention is currently required from: Robert Zieba, Jason Glenesk, Raul Rangel, Matt DeVillier, Angel Pons, Fred Reitberger, Karthik Ramasubramanian, Felix Held.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67936 )
Change subject: soc/amd/common/xhci: Add support for logging XHCI wake events ......................................................................
Patch Set 8:
(16 comments)
File src/soc/amd/common/block/include/amdblocks/xhci.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/f183ba1e_a8fdaf3d PS8, Line 16: SOC_XHCI_0,\ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/0bd6cb8f_d6c260de PS8, Line 17: SOC_XHCI_1,\ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/30439643_44826aff PS8, Line 18: SOC_XHCI_2,\ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/1c9df2b5_ef29f9ca PS8, Line 19: SOC_XHCI_3,\ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/6d7a7c68_6e9dd779 PS8, Line 20: SOC_XHCI_4,\ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/e08fa12e_f2f10f4f PS8, Line 21: SOC_XHCI_5,\ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/6d477a5a_e19a5d7a PS8, Line 22: SOC_XHCI_6,\ please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/977f0a7f_4dcd457d PS8, Line 23: SOC_XHCI_7,\ please, no spaces at the start of a line
File src/soc/amd/common/block/xhci/elog.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/f08aa86f_b7887e4a PS8, Line 13: #define PORTSC_OFFSET 0x400; macros should not use a trailing semicolon
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/5533307e_46b58ff1 PS8, Line 47: const struct xhci_context *context = (const struct xhci_context*)data; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/0cd3c0d3_dbcfda50 PS8, Line 50: (const struct xhci_capability_regs*)context->bar; "(foo*)" should be "(foo *)"
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/b12d389f_2bbc1616 PS8, Line 84: } Statements should start on a tabstop
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/37efb547_63062a3c PS8, Line 98: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/d1402080_6b3dff1e PS8, Line 104: const struct resource *res = (const struct resource*) &bar_store[i_bar].bars[0]; "(foo*)" should be "(foo *)"
File src/soc/amd/common/block/xhci/xhci.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/fd79ec82_f783b10b PS8, Line 12: trailing whitespace
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-164294): https://review.coreboot.org/c/coreboot/+/67936/comment/12a94ec9_b011ee06 PS8, Line 19: } adding a line without newline at end of file
-
build bot (Jenkins) (Code Review)