[L] Change in coreboot[main]: util/ifdtool: Add new cmdline to enable GPR0 protection

[Subrata Banik (Code Review)]

Attention is currently required from: Reka Norman, Stefan Reinauer.

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/80235?usp=email )

Change subject: util/ifdtool: Add new cmdline to enable GPR0 protection
......................................................................

Patch Set 5:

(6 comments)

File util/ifdtool/ifdtool.c:

https://review.coreboot.org/c/coreboot/+/80235/comment/edeaf9e2_2e626aae :
PS4, Line 47: union gprd_info
> nit: just `union gprd`? (I think you missed my previous comment about this)

Acknowledged

https://review.coreboot.org/c/coreboot/+/80235/comment/9bfd68c0_84a62834 :
PS4, Line 50: 		 * Start Address: bit 0-15 of the GPRD represents the protected region start address,
> nit: limit to 100 chars? Not sure if there's a guideline, but the rest of the file is under 100.

Acknowledged

https://review.coreboot.org/c/coreboot/+/80235/comment/e4227d19_c7194745 :
PS4, Line 50: 0-15
> `0-14` (or just drop this since it's implied from the bitfield)

Acknowledged

https://review.coreboot.org/c/coreboot/+/80235/comment/62d34428_4107a44e :
PS4, Line 1676: 	fpt++; /* Move to the next structure which is FPT sub-partition entries */
              : 	struct cse_fpt_sub_part *fpt_sub_part = (struct cse_fpt_sub_part *)fpt;
> nit: this could just be `struct cse_fpt_sub_part *fpt_sub_part = (struct cse_fpt_sub_part *)(fpt + 1 […]

Acknowledged

https://review.coreboot.org/c/coreboot/+/80235/comment/28e22852_5259b937 :
PS4, Line 1685: continue
> Don't need this

Acknowledged

https://review.coreboot.org/c/coreboot/+/80235/comment/be6ecffd_e82b2aa6 :
PS4, Line 1776:
> nit: `gprd.data.read_protect_en = 0`. […]

Acknowledged