Change in coreboot[master]: mb/google/brya/: Add PEG and initial Nvidia dGPU ASL support
Attention is currently required from: Subrata Banik, Paul Menzel, Michael Niewöhner. Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62931 )
Change subject: mb/google/brya/: Add PEG and initial Nvidia dGPU ASL support ......................................................................
Patch Set 3:
(5 comments)
Patchset:
PS2:
one more thought, if `nvjt/nvop` can exist inside `driver/nvidia/acpi` so we could reuse the same be […]
Yeah we'll see how the driver ends up looking, and extend it if needed.
PS2:
erm, oh. brain was slow and fingers were faster than my eyes. […]
Once we all have an upstream driver I would love to switch to that 😊
File src/mainboard/google/brya/acpi/gpu_top.asl:
https://review.coreboot.org/c/coreboot/+/62931/comment/af0889f2_fdb3c9b9 PS2, Line 3: #define NV_ERROR_SUCCESS 0x0 : #define NV_ERROR_UNSPECIFIED 0x80000001 : #define NV_ERROR_UNSUPPORTED 0x80000002
suggestion: may be `enum`?
Moved to a header file (I don't think ASL has enums)
https://review.coreboot.org/c/coreboot/+/62931/comment/76150427_4a1fbf49 PS2, Line 45: Device (PEGP)
if code block inside `PEGP` remains generic then I would suggest to split this file into 3 files […]
Done
File src/mainboard/google/brya/acpi/power.asl:
https://review.coreboot.org/c/coreboot/+/62931/comment/33131a81_5d5248ae PS2, Line 227:
multiple blank line?
Done
-
Tim Wawrzynczak (Code Review)