Attention is currently required from: Zheng Bao. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58554 )
Change subject: amdfwtool: Move PSP padding into a loop for combo ......................................................................
Patch Set 8:
(3 comments)
File util/amdfwtool/amdfwtool.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131298): https://review.coreboot.org/c/coreboot/+/58554/comment/7508b1bd_44cf2145 PS8, Line 1617: do { suspect code indent for conditional statements (8, 8)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131298): https://review.coreboot.org/c/coreboot/+/58554/comment/26cd3b09_26648099 PS8, Line 1666: if (!comboable) { suspect code indent for conditional statements (8, 8)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131298): https://review.coreboot.org/c/coreboot/+/58554/comment/dafebf07_a925978e PS8, Line 1704: if (!comboable) { suspect code indent for conditional statements (16, 16)
-
build bot (Jenkins) (Code Review)