Attention is currently required from: Maxim, Paul Menzel.
Sean Rhodes has posted comments on this change by Sean Rhodes. ( https://review.coreboot.org/c/coreboot/+/84633?usp=email )
Change subject: \ec/starlabs/merlin: Add support for setting the charging speed ......................................................................
Patch Set 10:
(6 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84633/comment/707a0255_5f3b6afa?usp... : PS9, Line 9: Allow boards that use the merlin EC to configure the charging speed.
Please elaborate, for example CMOS is used, and maybe reference the firmware API?
Done
https://review.coreboot.org/c/coreboot/+/84633/comment/e4e1221b_0ad1658d?usp... : PS9, Line 9: merlin EC
- Is a certain firmware version needed? […]
Done
https://review.coreboot.org/c/coreboot/+/84633/comment/c27bea85_0586a7a4?usp... : PS9, Line 10:
How was this tested?
Done
File src/ec/starlabs/merlin/Kconfig:
https://review.coreboot.org/c/coreboot/+/84633/comment/b3040d5f_51d7cf4c?usp... : PS9, Line 71: Select if the mainboard supports configuring the charging speed
Please add a dot/period at the end.
Done
https://review.coreboot.org/c/coreboot/+/84633/comment/23226364_679137cc?usp... : PS9, Line 71: Select if the mainboard supports configuring the charging speed
Mayeb elaborate, how this can be configured?
Done
File src/ec/starlabs/merlin/variants/merlin/ecdefs.h:
https://review.coreboot.org/c/coreboot/+/84633/comment/27e17428_91d95389?usp... : PS9, Line 23: ECRAM_MIRROR_FLAG
It seems to me that this has nothing to do with the charge speed. […]
Done