Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42685 )
Change subject: soc/amd/common: Drop ACPIMMIO bank for SMBus device PCI config
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
this breaks functionality
https://review.coreboot.org/c/coreboot/+/42685/8/src/soc/amd/picasso/uart.c
File src/soc/amd/picasso/uart.c:
https://review.coreboot.org/c/coreboot/+/42685/8/src/soc/amd/picasso/uart.c@...
PS8, Line 106: generator divisor programming? 16*115200 = 1.8432M. */
the register access below switches the clock source for the corresponding UART from 48MHz to 16*115200Hz. commenting out this code possibly breaks this legacy support
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c8ce8de0a6ab0ed41e7e8a5980d0f0510aaa993
Gerrit-Change-Number: 42685
Gerrit-PatchSet: 8
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Comment-Date: Mon, 21 Dec 2020 20:34:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment