Attention is currently required from: Dinesh Gehlot, Dtrain Hsu, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Paul Menzel, Subrata Banik.
John Su has posted comments on this change by John Su. ( https://review.coreboot.org/c/coreboot/+/86079?usp=email )
Change subject: mb/brya/var/uldrenite: Remove location setting in HDA verb tables
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/86079/comment/d7dc8f29_59c05e6f?usp... :
PS1, Line 7: Update HDA verb tables
Remove location setting in HDA verb tables
Done
File src/mainboard/google/brya/variants/uldrenite/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/86079/comment/a92fe9e8_88a40a15?usp... :
PS1, Line 7: 0x10ec0236, // Codec Vendor ID: Realtek ALC3204
Unrelated. Should be a separate patch with a tab instead of spaces.
Done
https://review.coreboot.org/c/coreboot/+/86079/comment/e74bc776_b65e8396?usp... :
PS1, Line 32: AZALIA_PIN_CFG(0, 0x21, 0x00211020),
Gerrit highlights the line. […]
0x02211020 => 0x00211020
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86079?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I05767ac80c2e3d609f944d0f669fcb343c1991ef
Gerrit-Change-Number: 86079
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Frank Wu
frank_wu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie_chen@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Tue, 21 Jan 2025 14:02:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org