[S] Change in coreboot[main]: arch/x86: introduce HAVE_CONFIGURABLE_APMC_SMI_PORT - coreboot-gerrit

4 Jan 2024


      Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79566?usp=email )
Change subject: arch/x86: introduce HAVE_CONFIGURABLE_APMC_SMI_PORT
......................................................................
Patch Set 3:
(1 comment)
File src/arch/x86/Kconfig:
https://review.coreboot.org/c/coreboot/+/79566/comment/e5170d6a_6a9d5b1f :
PS3, Line 322: non-fixed APMC SMI command port
...
on intel the io port is hard-wired while on amd the io port can be configured
would it make things clearer when replacing 'non-fixed' with 'configurable'?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/79566?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaceb61b0f2a630d7afe2e0780b6a2a9806ea62f9
Gerrit-Change-Number: 79566
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Jérémy Compostella jeremy.compostella@intel.com
Gerrit-Reviewer: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger reitbergerfred@gmail.com
Gerrit-Comment-Date: Thu, 04 Jan 2024 15:35:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier matt.devillier@amd.corp-partner.google.com
Comment-In-Reply-To: Felix Held felix-coreboot@felixheld.de
Gerrit-MessageType: comment