Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.
ot_song fan has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85842?usp=email )
Change subject: soc/mediatek/mt8196: Add srclken_rc drivers
......................................................................
Patch Set 6:
(2 comments)
File src/soc/mediatek/mt8196/include/soc/srclken_rc.h:
https://review.coreboot.org/c/coreboot/+/85842/comment/d1c81e68_9ffbafc8?usp... :
PS5, Line 190: #define REQ_TO_SPMI_P_MASK_SHFT 0
Remove
Done
File src/soc/mediatek/mt8196/srclken_rc.c:
https://review.coreboot.org/c/coreboot/+/85842/comment/93c706f4_e70a9e52?usp... :
PS1, Line 265: code flow ASSERT already
Okay, so you're saying the rc_mxx_req_sta_0 value will be determined by rc_mxx_srclken_cfg writes. […]
Thanks for your reply. We don't need to dump the rc_mxx_req_sta_0 values here, because we're confident that the values will be correct
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85842?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I40f8d2b12027955e6bd57b666e9f04c0116a0a93
Gerrit-Change-Number: 85842
Gerrit-PatchSet: 6
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: ot_song fan
ot_song.fan@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Comment-Date: Fri, 10 Jan 2025 07:52:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: ot_song fan
ot_song.fan@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com