Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37441 )
Change subject: src/mainboard/supermicro/x11-lga1151v2-series: Add Support for X11SCH-F ......................................................................
Patch Set 51:
(3 comments)
https://review.coreboot.org/c/coreboot/+/37441/51//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/37441/51//COMMIT_MSG@25 PS51, Line 25: Tested with Intel Xeon E-2186G and 64 GB ECC RAM.
How long does coreboot take to execute?
Feel free to mention your blog post [1].
[1]: https://9esec.io/blog/next-generation-coreboot-server-platform/
https://review.coreboot.org/c/coreboot/+/37441/49/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/ramstage.c:
https://review.coreboot.org/c/coreboot/+/37441/49/src/mainboard/supermicro/x... PS49, Line 14: * dependencies during hardware initialization. */ The first asterisk on the second line should be removed [1].
[1]: https://doc.coreboot.org/coding_style.html#commenting
https://review.coreboot.org/c/coreboot/+/37441/49/src/mainboard/supermicro/x... File src/mainboard/supermicro/x11-lga1151v2-series/variants/x11sch-f/include/variant/variants.h:
https://review.coreboot.org/c/coreboot/+/37441/49/src/mainboard/supermicro/x... PS49, Line 5: /* Return memory configuration structure. */ Please remove the dot at the end.