Attention is currently required from: Jason Glenesk, ritul guru, Paul Menzel, Fred Reitberger, Felix Held.
Anand Vaikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74075 )
Change subject: mb/amd/mayan: Correct PCIe bridge for M.2 NVMe SSD0
......................................................................
Patch Set 2:
(4 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74075/comment/73495ff4_c37fbb83
PS1, Line 7: Update the correct PCIe bridge for M.2 NVME SSD0
Maybe: […]
Done
https://review.coreboot.org/c/coreboot/+/74075/comment/fddd3f33_8894b0be
PS1, Line 7: mb/amd/mayan:Update the correct PCIe bridge for M.2 NVME SSD0
Please add a space after the colon.
Done
https://review.coreboot.org/c/coreboot/+/74075/comment/c60faa46_9063ca57
PS1, Line 8:
Please elaborate. Why is the new one correct? […]
Done
Patchset:
PS2:
Thanks for the review, I have addressed the comments.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I43096beda0405bd392574319d50e7cd6a7f8d291
Gerrit-Change-Number: 74075
Gerrit-PatchSet: 2
Gerrit-Owner: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: ritul guru
ritul.bits@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: ritul guru
ritul.bits@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 04 Apr 2023 04:30:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment