Change in ...coreboot[master]: google/grunt: Update Samsung K4AAG165WB-MCTD SPD Module Part Number
Hello Kevin Chiu,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/33018
to review the following change.
Change subject: google/grunt: Update Samsung K4AAG165WB-MCTD SPD Module Part Number ......................................................................
google/grunt: Update Samsung K4AAG165WB-MCTD SPD Module Part Number
Correct SPD Module Part Number to "K4AAG165WB-MCTD" from "M471A1K43BB1-CTD".
BUG=b:133478308 BRANCH=master TEST=emerge-grunt coreboot chromeos-bootimage mosys memory spd print all 0 | DDR4 | SO-DIMM 0 | 1-78: Samsung | 00000000 | K4AAG165WB-MCTD 0 | 8192 | 1 | 64 0 | DDR4-1333, DDR4-1600, DDR4-2400 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com
Change-Id: I5037ddfa99d8509c8a84a575348f8ae8d61f38a1 --- M src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCTD.spd.hex 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/33018/1
diff --git a/src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCTD.spd.hex b/src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCTD.spd.hex index ede001a..c50df63 100644 --- a/src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCTD.spd.hex +++ b/src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCTD.spd.hex @@ -19,8 +19,8 @@ 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 -80 CE 00 00 00 00 00 00 00 4D 34 37 31 41 31 4B -34 33 42 42 31 2D 43 54 44 20 20 20 20 00 80 CE +80 CE 00 00 00 00 00 00 00 4B 34 41 41 47 31 36 +35 57 42 2D 4D 43 54 44 20 20 20 20 20 00 80 CE 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00
Hello Kevin Chiu, build bot (Jenkins), Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33018
to look at the new patch set (#2).
Change subject: google/grunt: Update Samsung K4AAG165WB-MCTD SPD Module Part Number ......................................................................
google/grunt: Update Samsung K4AAG165WB-MCTD SPD Module Part Number
Correct SPD Module Part Number to "K4AAG165WB-MCTD" from "M471A1K43BB1-CTD".
BUG=b:133478308 BRANCH=master TEST=emerge-grunt coreboot chromeos-bootimage mosys memory spd print all 0 | DDR4 | SO-DIMM 0 | 1-78: Samsung | 00000000 | K4AAG165WB-MCTD 0 | 8192 | 1 | 64 0 | DDR4-1333, DDR4-1600, DDR4-2400 Change-Id: I5037ddfa99d8509c8a84a575348f8ae8d61f38a1 Signed-off-by: Kevin Chiu Kevin.Chiu@quantatw.com --- M src/mainboard/google/kahlee/variants/baseboard/spd/samsung-K4AAG165WB-MCTD.spd.hex 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/18/33018/2
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33018 )
Change subject: google/grunt: Update Samsung K4AAG165WB-MCTD SPD Module Part Number ......................................................................
Patch Set 2: Code-Review-1
This will break identification of this chip on all boards. RO will still have the old part number, but RW will have the new part number. Mosys looks for the SPDs in RO and won't be able to find them because the part number is different. This is what led to b:123179815 on careena where the memory information isn't populated.
Kevin Chiu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33018 )
Change subject: google/grunt: Update Samsung K4AAG165WB-MCTD SPD Module Part Number ......................................................................
Patch Set 2:
Patch Set 2: Code-Review-1
This will break identification of this chip on all boards. RO will still have the old part number, but RW will have the new part number. Mosys looks for the SPDs in RO and won't be able to find them because the part number is different. This is what led to b:123179815 on careena where the memory information isn't populated.
Hi Martin, so we'll need to separate this specific DRAM SPD for Careena only? thanks.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33018 )
Change subject: google/grunt: Update Samsung K4AAG165WB-MCTD SPD Module Part Number ......................................................................
Patch Set 2:
Hi Martin, so we'll need to separate this specific DRAM SPD for Careena only? thanks.
Hey Kevin, I'm really not sure how to answer that. I really don't think it should go on any systems right now. I've updated the bug with my concerns.
Kevin Chiu has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/33018 )
Change subject: google/grunt: Update Samsung K4AAG165WB-MCTD SPD Module Part Number ......................................................................
Abandoned
Hi Martin, thanks the comment on tracker, abandon this one to prevent things getting worse.
-
Kevin Chiu (Code Review) -
Martin Roth (Code Review)