Hannah Williams has posted comments on this change. ( https://review.coreboot.org/28060 )
Change subject: intel/common/block: Fix issues found by klockwork ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/cpu/mp_in... File src/soc/intel/common/block/cpu/mp_init.c:
https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/cpu/mp_in... PS2, Line 138: soc_init_cpus(dev->link_list); wrap it with if (dev && dev->link_list)
With the entries we have in devicetree.cb it will not be NULL though
https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/graphics/... File src/soc/intel/common/block/graphics/graphics.c:
https://review.coreboot.org/#/c/28060/2/src/soc/intel/common/block/graphics/... PS2, Line 43: if (!dev->enabled) if (!dev || !dev->enabled)
-
Hannah Williams (Code Review)