Attention is currently required from: Filip Brozovic, Matt DeVillier, Sean Rhodes.
Angel Pons has posted comments on this change by Filip Brozovic. ( https://review.coreboot.org/c/coreboot/+/86039?usp=email )
Change subject: CFR: Add min/max/step values and hex display flag for number options
......................................................................
Patch Set 2:
(1 comment)
File src/commonlib/include/commonlib/cfr.h:
https://review.coreboot.org/c/coreboot/+/86039/comment/0a8e9bc9_3837b282?usp... :
PS2, Line 139: uint32_t min;
: uint32_t max;
: uint32_t step;
Would it make more sense to instead put these values (as well as the display flags) into tagged varb […]
Yes, the CFR header is where a version number would be. If there isn't one, I would suggest making that breaking change first.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86039?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e70f1430fb1911f1ad974832f8abfe76f928ac3
Gerrit-Change-Number: 86039
Gerrit-PatchSet: 2
Gerrit-Owner: Filip Brozovic
fbrozovic@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Filip Brozovic
fbrozovic@gmail.com
Gerrit-Comment-Date: Sat, 18 Jan 2025 09:49:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Filip Brozovic
fbrozovic@gmail.com