[M] Change in coreboot[master]: soc/mediatek/common: Add support for power supply TPS65132S
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75488?usp=email )
Change subject: soc/mediatek/common: Add support for power supply TPS65132S ......................................................................
Patch Set 5:
(2 comments)
File src/soc/mediatek/common/tps65132s.c:
https://review.coreboot.org/c/coreboot/+/75488/comment/594537f0_db20b7c7 : PS5, Line 35: mdelay(10);
Where do these delays come from?
These delays come from previous CB:72749. Just keep the same as it.
https://review.coreboot.org/c/coreboot/+/75488/comment/539e3b88_fce4fe3d : PS5, Line 62: mdelay(50);
For such long delays, a comment mentioning section in the datasheet would be nice. […]
Got it. I will do it next times.
In this case, it comes from 8.5 section Programming in TPS65132-Single-Inductor-Dual-Output-Power-Supply.pdf
-
Ruihai Zhou (Code Review)