Attention is currently required from: Jason Glenesk, Jason Nien, Marshall Dawson, Matt DeVillier, Tim Wawrzynczak, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66994 )
Change subject: soc/amd: Refactor DPTC Tablet Mode
......................................................................
Patch Set 12:
(2 comments)
File src/soc/amd/cezanne/chip.h:
https://review.coreboot.org/c/coreboot/+/66994/comment/1070d84a_95bfc61c
PS10, Line 91: /* Enable dptc tablet mode */
: bool dptc_tablet_mode_enable;
Hrmm, how about you reorder your Cls. Move the CL that deletes the tablet mode before this one. […]
We never call `acpigen_write_alib_dptc` on cezanne though.
File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/66994/comment/2b51f76b_0ff1ec2c
PS10, Line 120: /* Enable dptc for tablet mode */
: bool dptc_enable;
As you pointed out, removing `dptc_enable` means the default DPTC settings can't be set without also […]
The default settings are always initially set by FSP, so we don't need any ACPI to handle that case. Since we don't use DPTC on CZN and MDN, we should be able to delete `dptc_enable` without any behavior change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66994
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2518fdd526868c9d5668a6018fd3570392e809c0
Gerrit-Change-Number: 66994
Gerrit-PatchSet: 12
Gerrit-Owner: Tim Van Patten
timvp@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Attention: Tim Van Patten
timvp@google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 06 Sep 2022 17:25:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Tim Van Patten
timvp@google.com
Gerrit-MessageType: comment