Attention is currently required from: Jason Glenesk, Jason Nien, Marshall Dawson, Matt DeVillier, Tim Wawrzynczak, Martin Roth, Tim Van Patten, Fred Reitberger, Felix Held.

View Change

2 comments:

• File src/soc/amd/cezanne/chip.h:

  • Patch Set #10, Line 91:

    	/* Enable dptc tablet mode */
    	bool dptc_tablet_mode_enable;
    

    > Hrmm, how about you reorder your Cls. Move the CL that deletes the tablet mode before this one. […]

    We never call `acpigen_write_alib_dptc` on cezanne though.

• File src/soc/amd/picasso/chip.h:

  • Patch Set #10, Line 120:

    	/* Enable dptc for tablet mode */
    	bool dptc_enable;
    

    As you pointed out, removing `dptc_enable` means the default DPTC settings can't be set without also […]

    The default settings are always initially set by FSP, so we don't need any ACPI to handle that case. Since we don't use DPTC on CZN and MDN, we should be able to delete `dptc_enable` without any behavior change.

To view, visit change 66994. To unsubscribe, or for help writing mail filters, visit settings.