Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37036 )
Change subject: device: Add back dummy HT_CHAIN_UNITID_BASE ......................................................................
device: Add back dummy HT_CHAIN_UNITID_BASE
This should be defined by mainboard. Add a dummy default to fix master while HyperTransport files are still around referencing this.
Change-Id: I58188a200a2cad5fa20affee1844117ba71ac338 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/device/Kconfig 1 file changed, 4 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37036/1
diff --git a/src/device/Kconfig b/src/device/Kconfig index 7f00c0b..45336a6 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -499,6 +499,10 @@ bool default n
+config HT_CHAIN_UNITID_BASE + int + default 0 + config PCIX_PLUGIN_SUPPORT bool default y
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37036 )
Change subject: device: Add back dummy HT_CHAIN_UNITID_BASE ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37036 )
Change subject: device: Add back dummy HT_CHAIN_UNITID_BASE ......................................................................
Patch Set 1:
HT_CHAIN_END_UNITID_BASE too?
Hello Aaron Durbin, Tim Wawrzynczak, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37036
to look at the new patch set (#2).
Change subject: device: Add back dummy HT_CHAIN_UNITID_BASE ......................................................................
device: Add back dummy HT_CHAIN_UNITID_BASE
This should be defined by mainboard. Add a dummy default to fix master while HyperTransport files are still around referencing this.
Change-Id: I58188a200a2cad5fa20affee1844117ba71ac338 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/device/Kconfig 1 file changed, 8 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/37036/2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37036 )
Change subject: device: Add back dummy HT_CHAIN_UNITID_BASE ......................................................................
Patch Set 2:
Patch Set 1:
HT_CHAIN_END_UNITID_BASE too?
Yes. These got removed on CB:36961 already, so probably some race with abuild that so many followups still got verified? I think I did not submit anything out-of-order.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37036 )
Change subject: device: Add back dummy HT_CHAIN_UNITID_BASE ......................................................................
Patch Set 2: Code-Review+2
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37036 )
Change subject: device: Add back dummy HT_CHAIN_UNITID_BASE ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37036 )
Change subject: device: Add back dummy HT_CHAIN_UNITID_BASE ......................................................................
device: Add back dummy HT_CHAIN_UNITID_BASE
This should be defined by mainboard. Add a dummy default to fix master while HyperTransport files are still around referencing this.
Change-Id: I58188a200a2cad5fa20affee1844117ba71ac338 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/37036 Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Arthur Heymans arthur@aheymans.xyz Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/device/Kconfig 1 file changed, 8 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/device/Kconfig b/src/device/Kconfig index 7f00c0b..9ae3bbd 100644 --- a/src/device/Kconfig +++ b/src/device/Kconfig @@ -499,6 +499,14 @@ bool default n
+config HT_CHAIN_UNITID_BASE + int + default 0 + +config HT_CHAIN_END_UNITID_BASE + int + default 0 + config PCIX_PLUGIN_SUPPORT bool default y
-
Aaron Durbin (Code Review) -
Arthur Heymans (Code Review)
-
Kyösti Mälkki (Code Review)
-
Tim Wawrzynczak (Code Review)