Change in coreboot[master]: soc/amd/common: Add some ESPI register definitions - coreboot-gerrit

5 Apr 2021


      Attention is currently required from: Jason Glenesk, Raul Rangel, Furquan Shaikh, Felix Held.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51747 )
Change subject: soc/amd/common: Add some ESPI register definitions
......................................................................
Patch Set 6:
(1 comment)
File src/soc/amd/common/block/include/amdblocks/espi.h:
https://review.coreboot.org/c/coreboot/+/51747/comment/d89ecc31_1fe27858 
PS6, Line 20: #define ESPI_IO_BASE_OFFSET_REG1		0x48
...
No, they're not required, but it seems useful to have them.
Ack.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51747
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieae53b12e5303641fb3f180c47468aaa6906e9af
Gerrit-Change-Number: 51747
Gerrit-PatchSet: 6
Gerrit-Owner: Martin Roth martinroth@google.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Furquan Shaikh furquan@google.com
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel rrangel@chromium.org
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Felix Held felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 05 Apr 2021 17:14:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel rrangel@chromium.org
Comment-In-Reply-To: Martin Roth martinroth@google.com
Gerrit-MessageType: comment