Felix Held has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48315 )
Change subject: soc/amd/picasso/chip.h: add missing device/device.h include ......................................................................
soc/amd/picasso/chip.h: add missing device/device.h include
Include device/device.h since it defines struct device_operations which is used in this file.
Change-Id: Ia92b778a5882d991b391dc29aeee0a5615677913 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/chip.h 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/48315/1
diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h index 28d2040..3dc70f7 100644 --- a/src/soc/amd/picasso/chip.h +++ b/src/soc/amd/picasso/chip.h @@ -7,6 +7,7 @@ #include <stdint.h> #include <amdblocks/chip.h> #include <commonlib/helpers.h> +#include <device/device.h> #include <drivers/i2c/designware/dw_i2c.h> #include <soc/i2c.h> #include <soc/iomap.h>
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48315 )
Change subject: soc/amd/picasso/chip.h: add missing device/device.h include ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48315/1/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/48315/1/src/soc/amd/picasso/chip.h@... PS1, Line 227: pci_domain_ops Actually, why is this required here? pci_domain_ops should really be a static object in chip.c.
Hello Jason Glenesk, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48315
to look at the new patch set (#2).
Change subject: soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops ......................................................................
soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops
Change-Id: Ia92b778a5882d991b391dc29aeee0a5615677913 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/chip.h 1 file changed, 0 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/48315/2
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48315 )
Change subject: soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops ......................................................................
Patch Set 2:
(1 comment)
that one took a different turn than expected
https://review.coreboot.org/c/coreboot/+/48315/1/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/48315/1/src/soc/amd/picasso/chip.h@... PS1, Line 227: pci_domain_ops
Actually, why is this required here? pci_domain_ops should really be a static object in chip.c.
oh, you're right. it is in chip.c
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48315 )
Change subject: soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48315/1/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/48315/1/src/soc/amd/picasso/chip.h@... PS1, Line 227: pci_domain_ops
oh, you're right. it is in chip. […]
You will also have to update pci_domain_ops in chip.c to be static now.
Hello build bot (Jenkins), Jason Glenesk, Marshall Dawson,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48315
to look at the new patch set (#3).
Change subject: soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops ......................................................................
soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops
Now pci_domain_ops in chip.c can also be marked as static.
Change-Id: Ia92b778a5882d991b391dc29aeee0a5615677913 Signed-off-by: Felix Held felix-coreboot@felixheld.de --- M src/soc/amd/picasso/chip.c M src/soc/amd/picasso/chip.h 2 files changed, 1 insertion(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/48315/3
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48315 )
Change subject: soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48315/1/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/48315/1/src/soc/amd/picasso/chip.h@... PS1, Line 227: pci_domain_ops
You will also have to update pci_domain_ops in chip.c to be static now.
done
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48315 )
Change subject: soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops ......................................................................
Patch Set 3: Code-Review+2
Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48315 )
Change subject: soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops ......................................................................
Patch Set 3: Code-Review+2
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48315 )
Change subject: soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops ......................................................................
soc/amd/picasso/chip.h: remove unneeded extern pci_domain_ops
Now pci_domain_ops in chip.c can also be marked as static.
Change-Id: Ia92b778a5882d991b391dc29aeee0a5615677913 Signed-off-by: Felix Held felix-coreboot@felixheld.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48315 Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Marshall Dawson marshalldawson3rd@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/picasso/chip.c M src/soc/amd/picasso/chip.h 2 files changed, 1 insertion(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Marshall Dawson: Looks good to me, approved
diff --git a/src/soc/amd/picasso/chip.c b/src/soc/amd/picasso/chip.c index 8384541..d31e94a 100644 --- a/src/soc/amd/picasso/chip.c +++ b/src/soc/amd/picasso/chip.c @@ -55,7 +55,7 @@ return NULL; };
-struct device_operations pci_domain_ops = { +static struct device_operations pci_domain_ops = { .read_resources = pci_domain_read_resources, .set_resources = pci_domain_set_resources, .scan_bus = pci_domain_scan_bus, diff --git a/src/soc/amd/picasso/chip.h b/src/soc/amd/picasso/chip.h index 28d2040..412cc08 100644 --- a/src/soc/amd/picasso/chip.h +++ b/src/soc/amd/picasso/chip.h @@ -223,6 +223,4 @@
typedef struct soc_amd_picasso_config config_t;
-extern struct device_operations pci_domain_ops; - #endif /* __PICASSO_CHIP_H__ */
-
Felix Held (Code Review) -
Furquan Shaikh (Code Review)
-
Marshall Dawson (Code Review)