[S] Change in coreboot[master]: soc/intel/meteorlake: Option to drop redundant CPU feature programming
Attention is currently required from: Tarun Tuli, Paul Menzel, Kapil Porwal, Ivy Jian, Eric Lai, Ronak Kanabar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74167 )
Change subject: soc/intel/meteorlake: Option to drop redundant CPU feature programming ......................................................................
Patch Set 1:
(8 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/74167/comment/88f93c55_ec6a0552 PS1, Line 7: Option to drop redundant CPU feature programming
“Allow to …” or “Add option to …”.
Ack
https://review.coreboot.org/c/coreboot/+/74167/comment/e16dadbd_7132c81d PS1, Line 14: these featureprogramming are
this feature programming is
Ack
https://review.coreboot.org/c/coreboot/+/74167/comment/4578548a_342fb3d9 PS1, Line 15: these
this
Ack
https://review.coreboot.org/c/coreboot/+/74167/comment/06434355_36748328 PS1, Line 17: would results
results
Ack
https://review.coreboot.org/c/coreboot/+/74167/comment/b9215d11_53bcce5c PS1, Line 17: in CPU exception
Give an example?
Ack
https://review.coreboot.org/c/coreboot/+/74167/comment/a5fedf83_c301e107 PS1, Line 19: to
should
Ack
https://review.coreboot.org/c/coreboot/+/74167/comment/5977c7dc_7fc7e295 PS1, Line 23: default
by default
Ack
https://review.coreboot.org/c/coreboot/+/74167/comment/9be0d089_f708f0b3 PS1, Line 25:
Can’t coreboot detect if that firmware volume is present?
I wish!
-
Subrata Banik (Code Review)