Attention is currently required from: Maciej Pijanowski, Jakub Czapiga, Karol Zmyslowski, Stefan Reinauer, Michal Zygowski.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73934 )
Change subject: util/inteltool: Add support for Jasper Lake ......................................................................
Patch Set 21:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/73934/comment/6f794581_dc3c67d1 PS21, Line 9: Tested on: GW-R86S-P1 This name is not descriptive, we typically add TEST= at the end of commit message with explanation hwo the change was verified. In this case giving the processor model would make much more sense. See other commit messages in the project to know what I mean
https://review.coreboot.org/c/coreboot/+/73934/comment/a9d3eaf5_be2700d6 PS21, Line 10: Documents: Intel Datasheet: 634545, rev. 001 : Document Number: Intel Pentium Silver and Intel : Celeron Processor Datasheet, vol. 2 of 2 Based on Intel Pentium Silver and Intel Celeron Processor Datasheet, vol. 2 of 2 revision 001 (DOC# 634545)
-
Michał Żygowski (Code Review)