Change in coreboot[master]: sc7280: Add Modem region in memlayout to avoid modem cleanup in Secbo...

[build bot (Jenkins) (Code Review)]

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58545 )

Change subject: sc7280: Add Modem region in memlayout to avoid modem cleanup in Secboot reboot.
......................................................................

Patch Set 1:

(7 comments)

File src/soc/qualcomm/sc7280/carve_out.c:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131203):
https://review.coreboot.org/c/coreboot/+/58545/comment/1b5b816a_d757aa5b 
PS1, Line 15: 	  printk(BIOS_DEBUG, " RAVI: %s : START : %p\n",__func__, _dram_modem);
space required after that ',' (ctx:VxV)

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131203):
https://review.coreboot.org/c/coreboot/+/58545/comment/9a090142_b4929556 
PS1, Line 16:           printk(BIOS_DEBUG, " RAVI: %s : END : %p\n",__func__, _edram_modem);
code indent should use tabs where possible

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131203):
https://review.coreboot.org/c/coreboot/+/58545/comment/bf5e7c34_f0f29de3 
PS1, Line 16:           printk(BIOS_DEBUG, " RAVI: %s : END : %p\n",__func__, _edram_modem);
please, no spaces at the start of a line

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131203):
https://review.coreboot.org/c/coreboot/+/58545/comment/9edad01b_62f99cc6 
PS1, Line 16:           printk(BIOS_DEBUG, " RAVI: %s : END : %p\n",__func__, _edram_modem);
space required after that ',' (ctx:VxV)

File src/soc/qualcomm/sc7280/soc.c:

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131203):
https://review.coreboot.org/c/coreboot/+/58545/comment/b1a5ec6a_551c75fe 
PS1, Line 27: 	if (soc_modem_carve_out(&start, &end))
that open brace { should be on the previous line

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131203):
https://review.coreboot.org/c/coreboot/+/58545/comment/68bb245a_63cf1d24 
PS1, Line 29: 		printk(BIOS_DEBUG, " RAVI: %s : START : %p\n",__func__, start);
space required after that ',' (ctx:VxV)

Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-131203):
https://review.coreboot.org/c/coreboot/+/58545/comment/7abe97bb_2dad19cb 
PS1, Line 30: 		printk(BIOS_DEBUG, " RAVI: %s : END : %p\n",__func__, end);
space required after that ',' (ctx:VxV)