Patrick Rudolph has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38930 )
Change subject: Documentation/lenovo: Replace RST code with markdown ......................................................................
Documentation/lenovo: Replace RST code with markdown
Latest Sphinx supports up path traversal in markdown. Replace old RST code that's no longer needed to prevent it being copy and pasted.
Change-Id: Ieec5cc1f8d91a7fbc003efae465f61e6b72b39dc Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M Documentation/mainboard/lenovo/t420.md M Documentation/mainboard/lenovo/t430.md M Documentation/mainboard/lenovo/t431s.md M Documentation/mainboard/lenovo/w530.md M Documentation/mainboard/lenovo/x1.md M Documentation/mainboard/lenovo/x301.md 6 files changed, 15 insertions(+), 20 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/38930/1
diff --git a/Documentation/mainboard/lenovo/t420.md b/Documentation/mainboard/lenovo/t420.md index 40665b4..00ce45f 100644 --- a/Documentation/mainboard/lenovo/t420.md +++ b/Documentation/mainboard/lenovo/t420.md @@ -14,12 +14,10 @@ the blue dot pictured) to orient the pins!
For more details have a look at [T420 / T520 / X220 / T420s / W520 common] and - -```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +the general [flashing tutorial].
Steps to access the flash IC are described here [T4xx series].
[T4xx series]: t4xx_series.md +[flashing tutorial]: ../../flash_tutorial/ext_power.md [T420 / T520 / X220 / T420s / W520 common]: Sandy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/t430.md b/Documentation/mainboard/lenovo/t430.md index 1ef4460..c2cddca 100644 --- a/Documentation/mainboard/lenovo/t430.md +++ b/Documentation/mainboard/lenovo/t430.md @@ -5,11 +5,10 @@ of the mainboard.
For more details have a look at [T430 / T530 / X230 / T430s / W530 common] and -```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +the general [flashing tutorial].
Steps to access the flash IC are described here [T4xx series].
+[flashing tutorial]: ../../flash_tutorial/ext_power.md [T4xx series]: t4xx_series.md [T430 / T530 / X230 / T430s / W530 common]: Ivy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/t431s.md b/Documentation/mainboard/lenovo/t431s.md index 48315a2..f177e0f 100644 --- a/Documentation/mainboard/lenovo/t431s.md +++ b/Documentation/mainboard/lenovo/t431s.md @@ -26,9 +26,7 @@
-```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +The general [flashing tutorial] has more details.
Currently, detecting the model of soldered RAM at runtime and loading the corresponding SPD datum from CBFS is not implemented yet. You may diff --git a/Documentation/mainboard/lenovo/w530.md b/Documentation/mainboard/lenovo/w530.md index 3b54303..e3fe6b8 100644 --- a/Documentation/mainboard/lenovo/w530.md +++ b/Documentation/mainboard/lenovo/w530.md @@ -10,9 +10,7 @@ both with an external programmer.
For more details have a look at [T430 / T530 / X230 / T430s / W530 common] and -```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +the general [flashing tutorial].
### After removing the keyboard and palm rest ![][w530-1] @@ -24,4 +22,5 @@
[w530-2]: w530-2.jpg
+[flashing tutorial]: ../../flash_tutorial/ext_power.md [T430 / T530 / X230 / T430s / W530 common]: Ivy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/x1.md b/Documentation/mainboard/lenovo/x1.md index 9758197..9f915bc 100644 --- a/Documentation/mainboard/lenovo/x1.md +++ b/Documentation/mainboard/lenovo/x1.md @@ -13,12 +13,10 @@ a piece of insulation tape.
For more details have a look at [T420 / T520 / X220 / T420s / W520 common] and - -```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +the general [flashing tutorial].
Steps to access the flash IC are described here [X2xx series].
[X2xx series]: x2xx_series.md +[flashing tutorial]: ../../flash_tutorial/ext_power.md [T420 / T520 / X220 / T420s / W520 common]: Sandy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/x301.md b/Documentation/mainboard/lenovo/x301.md index 28b512d..89b422f 100644 --- a/Documentation/mainboard/lenovo/x301.md +++ b/Documentation/mainboard/lenovo/x301.md @@ -26,9 +26,8 @@ -WINBOND_NEX_W25X64 (0xef, 0x3017) -ATMEL_AT25DF641 (0x1f, 0x4800)
-```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +The general [flashing tutorial] has more details. + Tested: - CPU Core 2 Duo U9400 - Slotted DIMM 4GiB*2 from samsung @@ -42,3 +41,7 @@ - S3 - Linux 4.19.67-2 within Debian GNU/Linux stable, loaded from Linux payload (Heads) and Seabios. + + +[flashing tutorial]: ../../flash_tutorial/ext_power.md +
Peter Lemenkov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38930 )
Change subject: Documentation/lenovo: Replace RST code with markdown ......................................................................
Patch Set 1: Code-Review+1
Looks good to me.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38930 )
Change subject: Documentation/lenovo: Replace RST code with markdown ......................................................................
Patch Set 1: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38930 )
Change subject: Documentation/lenovo: Replace RST code with markdown ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38930 )
Change subject: Documentation/lenovo: Replace RST code with markdown ......................................................................
Documentation/lenovo: Replace RST code with markdown
Latest Sphinx supports up path traversal in markdown. Replace old RST code that's no longer needed to prevent it being copy and pasted.
Change-Id: Ieec5cc1f8d91a7fbc003efae465f61e6b72b39dc Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/38930 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Peter Lemenkov lemenkov@gmail.com Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: Patrick Georgi pgeorgi@google.com --- M Documentation/mainboard/lenovo/t420.md M Documentation/mainboard/lenovo/t430.md M Documentation/mainboard/lenovo/t431s.md M Documentation/mainboard/lenovo/w530.md M Documentation/mainboard/lenovo/x1.md M Documentation/mainboard/lenovo/x301.md 6 files changed, 15 insertions(+), 20 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve Peter Lemenkov: Looks good to me, but someone else must approve
diff --git a/Documentation/mainboard/lenovo/t420.md b/Documentation/mainboard/lenovo/t420.md index 40665b4..00ce45f 100644 --- a/Documentation/mainboard/lenovo/t420.md +++ b/Documentation/mainboard/lenovo/t420.md @@ -14,12 +14,10 @@ the blue dot pictured) to orient the pins!
For more details have a look at [T420 / T520 / X220 / T420s / W520 common] and - -```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +the general [flashing tutorial].
Steps to access the flash IC are described here [T4xx series].
[T4xx series]: t4xx_series.md +[flashing tutorial]: ../../flash_tutorial/ext_power.md [T420 / T520 / X220 / T420s / W520 common]: Sandy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/t430.md b/Documentation/mainboard/lenovo/t430.md index 1ef4460..c2cddca 100644 --- a/Documentation/mainboard/lenovo/t430.md +++ b/Documentation/mainboard/lenovo/t430.md @@ -5,11 +5,10 @@ of the mainboard.
For more details have a look at [T430 / T530 / X230 / T430s / W530 common] and -```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +the general [flashing tutorial].
Steps to access the flash IC are described here [T4xx series].
+[flashing tutorial]: ../../flash_tutorial/ext_power.md [T4xx series]: t4xx_series.md [T430 / T530 / X230 / T430s / W530 common]: Ivy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/t431s.md b/Documentation/mainboard/lenovo/t431s.md index 48315a2..f177e0f 100644 --- a/Documentation/mainboard/lenovo/t431s.md +++ b/Documentation/mainboard/lenovo/t431s.md @@ -26,9 +26,7 @@
-```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +The general [flashing tutorial] has more details.
Currently, detecting the model of soldered RAM at runtime and loading the corresponding SPD datum from CBFS is not implemented yet. You may diff --git a/Documentation/mainboard/lenovo/w530.md b/Documentation/mainboard/lenovo/w530.md index 3b54303..e3fe6b8 100644 --- a/Documentation/mainboard/lenovo/w530.md +++ b/Documentation/mainboard/lenovo/w530.md @@ -10,9 +10,7 @@ both with an external programmer.
For more details have a look at [T430 / T530 / X230 / T430s / W530 common] and -```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +the general [flashing tutorial].
### After removing the keyboard and palm rest ![][w530-1] @@ -24,4 +22,5 @@
[w530-2]: w530-2.jpg
+[flashing tutorial]: ../../flash_tutorial/ext_power.md [T430 / T530 / X230 / T430s / W530 common]: Ivy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/x1.md b/Documentation/mainboard/lenovo/x1.md index 9758197..9f915bc 100644 --- a/Documentation/mainboard/lenovo/x1.md +++ b/Documentation/mainboard/lenovo/x1.md @@ -13,12 +13,10 @@ a piece of insulation tape.
For more details have a look at [T420 / T520 / X220 / T420s / W520 common] and - -```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +the general [flashing tutorial].
Steps to access the flash IC are described here [X2xx series].
[X2xx series]: x2xx_series.md +[flashing tutorial]: ../../flash_tutorial/ext_power.md [T420 / T520 / X220 / T420s / W520 common]: Sandy_Bridge_series.md diff --git a/Documentation/mainboard/lenovo/x301.md b/Documentation/mainboard/lenovo/x301.md index 28b512d..89b422f 100644 --- a/Documentation/mainboard/lenovo/x301.md +++ b/Documentation/mainboard/lenovo/x301.md @@ -26,9 +26,8 @@ -WINBOND_NEX_W25X64 (0xef, 0x3017) -ATMEL_AT25DF641 (0x1f, 0x4800)
-```eval_rst -:doc:`../../flash_tutorial/ext_power` -``` +The general [flashing tutorial] has more details. + Tested: - CPU Core 2 Duo U9400 - Slotted DIMM 4GiB*2 from samsung @@ -42,3 +41,7 @@ - S3 - Linux 4.19.67-2 within Debian GNU/Linux stable, loaded from Linux payload (Heads) and Seabios. + + +[flashing tutorial]: ../../flash_tutorial/ext_power.md +
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38930 )
Change subject: Documentation/lenovo: Replace RST code with markdown ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/674 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/673 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/672
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Patrick Georgi (Code Review)
-
Patrick Rudolph (Code Review)
-
Paul Menzel (Code Review)
-
Peter Lemenkov (Code Review)