Attention is currently required from: Jason Nien, Jon Murphy, Martin Roth.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79792?usp=email )
Change subject: mb/google/guybrush: Update DXIO descriptor definition
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/google/guybrush/variants/baseboard/port_descriptors.c:
https://review.coreboot.org/c/coreboot/+/79792/comment/a2cd7530_c92bef81 :
PS2, Line 29: variant_sd_aux_reset_gpio
nit: line length.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79792?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6a61d6561304782de847f6b99c9a73292e12b33f
Gerrit-Change-Number: 79792
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Reviewer: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jason Nien
jason.nien@amd.corp-partner.google.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Attention: Martin Roth
martin.roth@amd.corp-partner.google.com
Gerrit-Comment-Date: Fri, 05 Jan 2024 18:06:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment