Attention is currently required from: Furquan Shaikh, Paul Menzel, Angel Pons, Julius Werner, Karthik Ramasubramanian.
Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56579 )
Change subject: arch/x86/Makefile: Align VGA_BIOS to 64 bytes when using AMD LPC SPI DMA
......................................................................
Patch Set 6:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/56579/comment/0d329e09_e227d377
PS6, Line 9: AMD platforms require the SPI contents to be 64 byte aligned in order to
: use the SPI DMA controller.
If I understand this correctly, it means other files could potentially have the same issue, not just […]
Correct. So I might need to add alignment attributes in other places when I get around to preloading those assets.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56579
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I842c85288acd8f7ac99b127c94b1cf235e264ea2
Gerrit-Change-Number: 56579
Gerrit-PatchSet: 6
Gerrit-Owner: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Fri, 29 Oct 2021 18:29:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment