Martin Roth has submitted this change. ( https://review.coreboot.org/c/coreboot/+/64218 )
Change subject: superio/acpi/pnp_generic.asl: Add _PRS for each device ......................................................................
superio/acpi/pnp_generic.asl: Add _PRS for each device
Simply return the current resource settings in the _PRS method. This means that coreboot has to correctly set up the resources on the device. This won't result in any regression as without _PRS the ACPI OS would not know what resources settings are valid, so it would never use _SRS.
Change-Id: I2726714cbe076fc7c772c06883d8551400ff2baa Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/64218 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Elyes Haouas ehaouas@noos.fr Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martin.roth@amd.corp-partner.google.com --- M src/superio/acpi/pnp_generic.asl 1 file changed, 29 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, but someone else must approve Elyes Haouas: Looks good to me, approved Martin Roth: Looks good to me, approved
diff --git a/src/superio/acpi/pnp_generic.asl b/src/superio/acpi/pnp_generic.asl index d0d9a2d..2bcc139 100644 --- a/src/superio/acpi/pnp_generic.asl +++ b/src/superio/acpi/pnp_generic.asl @@ -171,4 +171,12 @@ Store (One, PNP_DEVICE_ACTIVE) EXIT_CONFIG_MODE () } + + /* This is used for _SRS. Since _DIS only disables the device + * without changing the resources this works. + */ + Method (_PRS, 0) + { + return (_CRS) + } }