Attention is currently required from: Benjamin Doron, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40625 )
Change subject: [WIP] skl: PEG for Optimus ......................................................................
Patch Set 15:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/40625/comment/0c9ff186_4e089fe9 PS9, Line 7: PEG
PEG usually refers to the PCIe root port that is directly attached to the CPU (PCI device 00:01.0). If this is actually for the PCIe root ports on the PCH, I would be against calling it "PEG" to avoid confusion.
What would you prefer? Note that this attempts to handle both situations, although I cannot test CPU PEG.
For the commit summary, I would use `ACPI`.
Note that SKL-U, SKL-Y and friends (e.g. KBL) do not have the PEG PCI devices (00:01.0) at all.
(FWIW, note that PEG can be bifurcated, in which case additional PCI functions 1 and 2 can be present for PEG)
Would a dGPU have function 2? I am aware that an HDA controller at function 1 is sometimes present.
I am talking about the PEG PCI devices and functions. I mean that PCI devices 00:01.1 and 00:01.2 can exist sometimes.
File src/soc/intel/skylake/acpi/peg.asl:
https://review.coreboot.org/c/coreboot/+/40625/comment/9cf0c429_d301060a PS15, Line 7: SKYLAKE_SOC_PCH_H
this is wrong. The Kconfig is about the PCH, not the CPU. […]
This is right, because platforms with PCH-H have separate packages for the CPU and PCH, and also have PCIe ports on the CPU.
https://review.coreboot.org/c/coreboot/+/40625/comment/26892e05_4e29b4e0 PS15, Line 13: Skylake
mobile sylake do have peg ports
It's ULT parts that do not have PEG.