Attention is currently required from: Benjamin Doron, Angel Pons. Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40625 )
Change subject: [WIP] skl: PEG for Optimus ......................................................................
Patch Set 15:
(4 comments)
File src/soc/intel/skylake/acpi/peg.asl:
https://review.coreboot.org/c/coreboot/+/40625/comment/5d82e202_829856eb PS15, Line 7: SKYLAKE_SOC_PCH_H this is wrong. The Kconfig is about the PCH, not the CPU. All skylake soc should set this, even when the device is disabled.
https://review.coreboot.org/c/coreboot/+/40625/comment/39e04bde_935d6f64 PS15, Line 13: Skylake mobile sylake do have peg ports
https://review.coreboot.org/c/coreboot/+/40625/comment/da108ae6_257c824e PS15, Line 223: 0x69 that GPE is likely board specific, is it?
https://review.coreboot.org/c/coreboot/+/40625/comment/a28fb55d_83bc9fb8 PS15, Line 234: , this backups and restores 256 bytes of PCI config space, but that can be accived using OperationRegion and "PCI_Config" as well. Why is it even necessary to backup and restore registers?