Change in coreboot[master]: cpu/intel/model_6xx: Align cosmetics
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44240 ) Change subject: cpu/intel/model_6xx: Align cosmetics ...................................................................... cpu/intel/model_6xx: Align cosmetics Add a comment and remove some spaces to align with similar CPUs. Change-Id: I825766a638581b247281df9d16bcfb9c02a43dad Signed-off-by: Angel Pons <th3fanbus@gmail.com> --- M src/cpu/intel/model_6xx/model_6xx_init.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/44240/1 diff --git a/src/cpu/intel/model_6xx/model_6xx_init.c b/src/cpu/intel/model_6xx/model_6xx_init.c index f394b5f..8ebc7ee 100644 --- a/src/cpu/intel/model_6xx/model_6xx_init.c +++ b/src/cpu/intel/model_6xx/model_6xx_init.c @@ -14,6 +14,8 @@ /* Turn on caching if we haven't already */ x86_enable_cache(); + + /* Setup MTRRs */ x86_setup_mtrrs(); x86_mtrr_check(); @@ -22,7 +24,7 @@ }; static struct device_operations cpu_dev_ops = { - .init = model_6xx_init, + .init = model_6xx_init, }; static const struct cpu_device_id cpu_table[] = { -- To view, visit https://review.coreboot.org/c/coreboot/+/44240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I825766a638581b247281df9d16bcfb9c02a43dad Gerrit-Change-Number: 44240 Gerrit-PatchSet: 1 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-MessageType: newchange
Hello Keith Hui, build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44240 to look at the new patch set (#2). Change subject: cpu/intel/model_6xx: Align cosmetics ...................................................................... cpu/intel/model_6xx: Align cosmetics Add a comment and remove some spaces to align with similar CPUs. Change-Id: I825766a638581b247281df9d16bcfb9c02a43dad Signed-off-by: Angel Pons <th3fanbus@gmail.com> --- M src/cpu/intel/model_6xx/model_6xx_init.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/44240/2 -- To view, visit https://review.coreboot.org/c/coreboot/+/44240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I825766a638581b247281df9d16bcfb9c02a43dad Gerrit-Change-Number: 44240 Gerrit-PatchSet: 2 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
Hello Keith Hui, build bot (Jenkins), Patrick Rudolph, I'd like you to reexamine a change. Please visit https://review.coreboot.org/c/coreboot/+/44240 to look at the new patch set (#4). Change subject: cpu/intel/model_6xx: Align cosmetics ...................................................................... cpu/intel/model_6xx: Align cosmetics Add a comment and remove some spaces to align with similar CPUs. Change-Id: I825766a638581b247281df9d16bcfb9c02a43dad Signed-off-by: Angel Pons <th3fanbus@gmail.com> --- M src/cpu/intel/model_6xx/model_6xx_init.c 1 file changed, 3 insertions(+), 1 deletion(-) git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/44240/4 -- To view, visit https://review.coreboot.org/c/coreboot/+/44240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I825766a638581b247281df9d16bcfb9c02a43dad Gerrit-Change-Number: 44240 Gerrit-PatchSet: 4 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: newpatchset
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44240 ) Change subject: cpu/intel/model_6xx: Align cosmetics ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/44240/5/src/cpu/intel/model_6xx/mod... File src/cpu/intel/model_6xx/model_6xx_init.c: https://review.coreboot.org/c/coreboot/+/44240/5/src/cpu/intel/model_6xx/mod... PS5, Line 18: /* Setup MTRRs */ I'd remove this form the other files. -- To view, visit https://review.coreboot.org/c/coreboot/+/44240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I825766a638581b247281df9d16bcfb9c02a43dad Gerrit-Change-Number: 44240 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 09 Aug 2020 05:38:03 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44240 ) Change subject: cpu/intel/model_6xx: Align cosmetics ...................................................................... Patch Set 5: (1 comment) https://review.coreboot.org/c/coreboot/+/44240/5/src/cpu/intel/model_6xx/mod... File src/cpu/intel/model_6xx/model_6xx_init.c: https://review.coreboot.org/c/coreboot/+/44240/5/src/cpu/intel/model_6xx/mod... PS5, Line 18: /* Setup MTRRs */
I'd remove this form the other files. I'd say this is a matter of personal preference, and I wouldn't want to re-do the patch train again just to change this. Plus, Keith (or someone else with this hardware) still needs to test a few things.
Maybe we can handle this once the bottom half of this patch train (yes, these commits without any reviews) is merged? -- To view, visit https://review.coreboot.org/c/coreboot/+/44240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I825766a638581b247281df9d16bcfb9c02a43dad Gerrit-Change-Number: 44240 Gerrit-PatchSet: 5 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-Comment-Date: Sun, 09 Aug 2020 07:33:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-MessageType: comment
Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/44240 ) Change subject: cpu/intel/model_6xx: Align cosmetics ...................................................................... Abandoned Sorry, I ran out of patience and energy to care about these changes any longer. -- To view, visit https://review.coreboot.org/c/coreboot/+/44240 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I825766a638581b247281df9d16bcfb9c02a43dad Gerrit-Change-Number: 44240 Gerrit-PatchSet: 6 Gerrit-Owner: Angel Pons <th3fanbus@gmail.com> Gerrit-Reviewer: Keith Hui <buurin@gmail.com> Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: HAOUAS Elyes <ehaouas@noos.fr> Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net> Gerrit-MessageType: abandon
participants (2)
-
Angel Pons (Code Review) -
HAOUAS Elyes (Code Review)