Attention is currently required from: Tarun Tuli, Rizwan Qureshi, Sridhar Siricilla.
Kapil Porwal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69698 )
Change subject: soc/intel/meteorlake: Rename method is_eom to is_manuf_mode
......................................................................
Patch Set 1:
(1 comment)
File src/soc/intel/meteorlake/me.c:
https://review.coreboot.org/c/coreboot/+/69698/comment/f6942b7b_c9856455
PS1, Line 79: is_manuf_mode
Kapil, Hmm..I miss the negation. But, is_manuf_mode() naming has no meaning. […]
If not specified (enabled/disabled) it is always considered as enabled.
This is an effort to minimize the difference between ADL & MTL implementations so that later we can move most of the code to the common code.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69698
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d2de3365126ba618c987c412c4e9784012f9e0b
Gerrit-Change-Number: 69698
Gerrit-PatchSet: 1
Gerrit-Owner: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Attention: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Comment-Date: Wed, 23 Nov 2022 09:59:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kapil Porwal
kapilporwal@google.com
Comment-In-Reply-To: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-MessageType: comment