Attention is currently required from: chris wang.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52900 )
Change subject: mb/google/mancomb: Update AMDFW config file
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/google/mancomb/variants/baseboard/amdfw.cfg:
https://review.coreboot.org/c/coreboot/+/52900/comment/900af606_90d3e25a
PS1, Line 37: PSP_PMUI_FILE1 TypeId0x65_Appb_CZN_1D_Ddr4_Udimm_Dmem.csbin
: PSP_PMUD_FILE2 TypeId0x64_Appb_CZN_2D_Ddr4_Udimm_Imem.csbin
It should like below. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52900
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icc4dc8aec2053cb177765f57e57cac7a099508fe
Gerrit-Change-Number: 52900
Gerrit-PatchSet: 2
Gerrit-Owner: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ivy Jian
ivy_jian@compal.corp-partner.google.com
Gerrit-CC: chris wang
Chris.Wang@amd.com
Gerrit-Attention: chris wang
Chris.Wang@amd.com
Gerrit-Comment-Date: Fri, 07 May 2021 02:54:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson
marshalldawson3rd@gmail.com
Comment-In-Reply-To: chris wang
Chris.Wang@amd.com
Gerrit-MessageType: comment