Attention is currently required from: Dinesh Gehlot, Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Karthik Ramasubramanian, Nick Vaccaro, Subrata Banik.
Jérémy Compostella has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86227?usp=email )
Change subject: soc/intel/adl: Handle critical low battery early in romstage
......................................................................
Patch Set 1:
(2 comments)
File src/soc/intel/alderlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/86227/comment/164bf92e_42b2c126?usp... :
PS1, Line 427: google_chromeec_reboot(EC_REBOOT_COLD_AP_OFF,0);
`space required after that ',' (ctx:VxV)`
Please fix.
https://review.coreboot.org/c/coreboot/+/86227/comment/2536b4ae_e2c92583?usp... :
PS1, Line 446: is_early_critical_shutdown_needed
A function start with `is_` is commonly expected to return a boolean and to not take any action. I would suggest to rename it. What about `early_shutdown_if_battery_below_critical_threshold` ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86227?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ib4be86ed17818ee05b7bec0337a90f80017183c2
Gerrit-Change-Number: 86227
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-CC: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 30 Jan 2025 17:01:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No