Change in coreboot[master]: vendorcode/google/dram_part_num: Fix the severity of debug statement

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46299 )

Change subject: vendorcode/google/dram_part_num: Fix the severity of debug statement
......................................................................

vendorcode/google/dram_part_num: Fix the severity of debug statement

DRAM part number may not be provisioned in CBI during early stages of
development. Logging the debug statement with error severity interferes
with some of the test tools. Update the severity of the debug statement
to just DEBUG severity

BUG=b:170529094
TEST=Build and boot to ChromeOS in Drawlat.

Change-Id: Ib0c707ec6478060d6e18ea01cc467dfda00a6d42
Signed-off-by: Karthikeyan Ramasubramanian 
---
M src/vendorcode/google/chromeos/dram_part_num_override.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46299/1

diff --git a/src/vendorcode/google/chromeos/dram_part_num_override.c b/src/vendorcode/google/chromeos/dram_part_num_override.c
index d624e13..4b934fe 100644
--- a/src/vendorcode/google/chromeos/dram_part_num_override.c
+++ b/src/vendorcode/google/chromeos/dram_part_num_override.c
@@ -16,8 +16,8 @@
    if (part_num_state == PART_NUM_NOT_READ) {
    	if (google_chromeec_cbi_get_dram_part_num(part_num_store,
    					  sizeof(part_num_store)) < 0) {
-			printk(BIOS_ERR,
-			  "ERROR: Couldn't obtain DRAM part number from CBI\n");
+			printk(BIOS_DEBUG,
+			  "Couldn't obtain DRAM part number from CBI\n");
    		part_num_state = PART_NUM_NOT_IN_CBI;
    	} else {
    		part_num_state = PART_NUM_AVAILABLE;

[Justin TerAvest (Code Review)]

Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46299 )

Change subject: vendorcode/google/dram_part_num: Fix the severity of debug statement
......................................................................

Patch Set 1: Code-Review+2

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46299 )

Change subject: vendorcode/google/dram_part_num: Fix the severity of debug statement
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46299/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46299/1//COMMIT_MSG@7 
PS1, Line 7: Fix the severity of debug statement
I wouldn't call this a fix. An actual fix would be to account for this in the test tools, but I imagine it would not be trivial to implement. So, how about:

Lower severity of debug statement

Change in coreboot[master]: vendorcode/google/dram_part_num: Lower the severity of debug statement

[Karthik Ramasubramanian (Code Review)]

Hello build bot (Jenkins), Furquan Shaikh, Justin TerAvest, Tim Wawrzynczak, Nick Vaccaro,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46299

to look at the new patch set (#2).

Change subject: vendorcode/google/dram_part_num: Lower the severity of debug statement
......................................................................

vendorcode/google/dram_part_num: Lower the severity of debug statement

DRAM part number may not be provisioned in CBI during early stages of
development. Logging the debug statement with error severity interferes
with some of the test tools. Lower the severity of debug statement to
BIOS_DEBUG.

BUG=b:170529094
TEST=Build and boot to ChromeOS in Drawlat.

Change-Id: Ib0c707ec6478060d6e18ea01cc467dfda00a6d42
Signed-off-by: Karthikeyan Ramasubramanian 
---
M src/vendorcode/google/chromeos/dram_part_num_override.c
1 file changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/99/46299/2

Change in coreboot[master]: vendorcode/google/dram_part_num: Lower the severity of debug statement

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46299 )

Change subject: vendorcode/google/dram_part_num: Lower the severity of debug statement
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/46299/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46299/1//COMMIT_MSG@7 
PS1, Line 7: Fix the severity of debug statement
> I wouldn't call this a fix. […]

Done

Change in coreboot[master]: vendorcode/google/dram_part_num: Lower the severity of debug statement

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46299 )

Change subject: vendorcode/google/dram_part_num: Lower the severity of debug statement
......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/c/coreboot/+/46299/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/46299/1//COMMIT_MSG@7 
PS1, Line 7: Fix the severity of debug statement
> Done

Thanks

Change in coreboot[master]: vendorcode/google/dram_part_num: Lower the severity of debug statement

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46299 )

Change subject: vendorcode/google/dram_part_num: Lower the severity of debug statement
......................................................................

vendorcode/google/dram_part_num: Lower the severity of debug statement

DRAM part number may not be provisioned in CBI during early stages of
development. Logging the debug statement with error severity interferes
with some of the test tools. Lower the severity of debug statement to
BIOS_DEBUG.

BUG=b:170529094
TEST=Build and boot to ChromeOS in Drawlat.

Change-Id: Ib0c707ec6478060d6e18ea01cc467dfda00a6d42
Signed-off-by: Karthikeyan Ramasubramanian 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/46299
Reviewed-by: Angel Pons 
Reviewed-by: Justin TerAvest 
Tested-by: build bot (Jenkins) 
---
M src/vendorcode/google/chromeos/dram_part_num_override.c
1 file changed, 2 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Justin TerAvest: Looks good to me, approved
  Angel Pons: Looks good to me, approved

diff --git a/src/vendorcode/google/chromeos/dram_part_num_override.c b/src/vendorcode/google/chromeos/dram_part_num_override.c
index d624e13..4b934fe 100644
--- a/src/vendorcode/google/chromeos/dram_part_num_override.c
+++ b/src/vendorcode/google/chromeos/dram_part_num_override.c
@@ -16,8 +16,8 @@
    if (part_num_state == PART_NUM_NOT_READ) {
    	if (google_chromeec_cbi_get_dram_part_num(part_num_store,
    					  sizeof(part_num_store)) < 0) {
-			printk(BIOS_ERR,
-			  "ERROR: Couldn't obtain DRAM part number from CBI\n");
+			printk(BIOS_DEBUG,
+			  "Couldn't obtain DRAM part number from CBI\n");
    		part_num_state = PART_NUM_NOT_IN_CBI;
    	} else {
    		part_num_state = PART_NUM_AVAILABLE;