Hello Matt DeVillier,
I'd like you to do a code review. Please visit
https://review.coreboot.org/19985
to review the following change.
Change subject: purism/librem13v1: Set FADT revision to ACPI 3.0 ......................................................................
purism/librem13v1: Set FADT revision to ACPI 3.0
The FADT revision was set to 5, but we do not implement the ACPI v5.0 specification, which prevented Windows from booting. Setting it to v3 (matching most other boards) fixes the issue and Windows now boots normally. Bug found by Matt DeVillier, fix tested by Youness Alaoui on Librem 13 v1 hardware.
Change-Id: Ide97cbf64f7b05018433436431ab4723b217fe22 Signed-off-by: Youness Alaoui youness.alaoui@puri.sm Signed-off-by: Matt DeVillier matt.devillier@gmail.com --- M src/mainboard/purism/librem13v1/fadt.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/19985/1
diff --git a/src/mainboard/purism/librem13v1/fadt.c b/src/mainboard/purism/librem13v1/fadt.c index 980ff03..9cbcd3f 100644 --- a/src/mainboard/purism/librem13v1/fadt.c +++ b/src/mainboard/purism/librem13v1/fadt.c @@ -23,7 +23,7 @@ memset(fadt, 0, sizeof(acpi_fadt_t)); memcpy(header->signature, "FACP", 4); header->length = sizeof(acpi_fadt_t); - header->revision = 5; + header->revision = ACPI_FADT_REV_ACPI_3_0; memcpy(header->oem_id, OEM_ID, 6); memcpy(header->oem_table_id, ACPI_TABLE_CREATOR, 8); memcpy(header->asl_compiler_id, ASLC, 4);