[M] Change in coreboot[master]: mb/google/zork: Implement touchscreen power sequencing

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/69456 )

Change subject: mb/google/zork: Implement touchscreen power sequencing
......................................................................

mb/google/zork: Implement touchscreen power sequencing

As all variants have a touchscreen option, in baseboard tables set the
enable GPIO high and hold in reset during romstage, then release reset
in ramstage. This will allow the touchscreen to make use of the runtime
I2C detect feature (enabled in a subsequent commit) so that an ACPI
device entry is created only for the touchscreen actually present.

This mirrors the change to skyrim in commit f90ff456
(mb/google/skyrim: Implement touchscreen power sequencing)

Change-Id: Ifdd75cd96e7b6880085a3f47214b92948a56aa2e
Signed-off-by: Matt DeVillier 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/69456
Reviewed-by: Angel Pons 
Reviewed-by: Martin Roth 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
M src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
2 files changed, 43 insertions(+), 8 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Angel Pons: Looks good to me, but someone else must approve
  Martin Roth: Looks good to me, approved

diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
index 3953a92..5d68ee9 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_dalboz.c
@@ -64,7 +64,7 @@
    /* EC_AP_INT_ODL (Sensor Framesync) */
    PAD_GPI(GPIO_31, PULL_NONE),
    /* EN_PWR_TOUCHSCREEN */
-	PAD_GPO(GPIO_32, LOW),
+	PAD_GPO(GPIO_32, HIGH),
    /* GPIO_33 - GPIO_39: Not available */
    /* NVME_AUX_RESET_L */
    PAD_GPO(GPIO_40, HIGH),
@@ -148,8 +148,8 @@
    PAD_NF(GPIO_138, UART0_TXD, PULL_NONE),
    /* DEV_BEEP_BCLK */
    PAD_GPI(GPIO_139, PULL_NONE),
-	/* USI_RESET_L */
-	PAD_GPO(GPIO_140, LOW),
+	/* TOUCHSCREEN_RESET_L */
+	PAD_GPO(GPIO_140, HIGH),
    /* USB_HUB_RST_L */
    PAD_GPO(GPIO_141, HIGH),
    /* SD_AUX_RESET_L */
@@ -354,7 +354,13 @@
    return early_gpio_table;
 }

-static const struct soc_amd_gpio romstage_gpio_table[] = {};
+static const struct soc_amd_gpio romstage_gpio_table[] = {
+	/* Enable touchscreen, hold in reset */
+	/* EN_PWR_TOUCHSCREEN */
+	PAD_GPO(GPIO_32, HIGH),
+	/* TOUCHSCREEN_RESET_L */
+	PAD_GPO(GPIO_140, LOW),
+};

const struct soc_amd_gpio *baseboard_romstage_gpio_table(size_t *size)
 {
diff --git a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
index 17c00db..ef9eab2 100644
--- a/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
+++ b/src/mainboard/google/zork/variants/baseboard/gpio_baseboard_trembyle.c
@@ -108,7 +108,7 @@
    /* GPIO_89 - unused */
    PAD_NC(GPIO_89),
    /* EN_PWR_TOUCHSCREEN */
-	PAD_GPO(GPIO_90, LOW),
+	PAD_GPO(GPIO_90, HIGH),
    /* EN_SPKR */
    PAD_GPO(GPIO_91, LOW),
    /* CLK_REQ0_L - WIFI */
@@ -160,8 +160,8 @@
    PAD_NF(GPIO_138, UART0_TXD, PULL_NONE),
    /* DEV_BEEP_BCLK */
    PAD_GPI(GPIO_139, PULL_NONE),
-	/* USI_RESET_L */
-	PAD_GPO(GPIO_140, LOW),
+	/* TOUCHSCREEN_RESET_L */
+	PAD_GPO(GPIO_140, HIGH),
    /* UART1_RXD - FPMCU */
    PAD_NF(GPIO_141, UART1_RXD, PULL_NONE),
    /* SD_AUX_RESET_L */
@@ -403,7 +403,13 @@
    return early_gpio_table;
 }

-static const struct soc_amd_gpio romstage_gpio_table[] = {};
+static const struct soc_amd_gpio romstage_gpio_table[] = {
+	/* Enable touchscreen, hold in reset */
+	/* EN_PWR_TOUCHSCREEN */
+	PAD_GPO(GPIO_32, HIGH),
+	/* TOUCHSCREEN_RESET_L */
+	PAD_GPO(GPIO_140, LOW),
+};

const struct soc_amd_gpio *baseboard_romstage_gpio_table(size_t *size)
 {