Attention is currently required from: Ana Carolina Cabral.
Angel Pons has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/84776?usp=email )
Change subject: drivers/amd/nova: Add Nova Card common driver
......................................................................
Patch Set 10: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/84776/comment/8fa21438_9b21b30e?usp... :
PS10, Line 7: drivers/amd/nova: Add Nova Card common driver
Out of curiosity, what is a Nova/NOVA card?
File src/drivers/amd/nova/nova_card.c:
https://review.coreboot.org/c/coreboot/+/84776/comment/4ce2b263_bfc99629?usp... :
PS10, Line 28: switch (connector_type) {
`switch and case should be at the same indent`
Please fix (remove one tab across the entire switch body)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/84776?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5e9ded2090d6a5865e3330408f490e59fbf480f4
Gerrit-Change-Number: 84776
Gerrit-PatchSet: 10
Gerrit-Owner: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alicja Michalska
ahplka19@gmail.com
Gerrit-CC: Anand Vaikar
a.vaikar2021@gmail.com
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Ana Carolina Cabral
ana.cpmelo95@gmail.com
Gerrit-Comment-Date: Tue, 11 Feb 2025 11:27:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes