Andrey Petrov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39133 )
Change subject: md/kontron/mal10: Add COMe-mAL10 minimal support
......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/39133/8//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/39133/8//COMMIT_MSG@7
PS8, Line 7: md
mb?
https://review.coreboot.org/c/coreboot/+/39133/8/src/mainboard/kontron/mal10...
File src/mainboard/kontron/mal10/gpio.h:
https://review.coreboot.org/c/coreboot/+/39133/8/src/mainboard/kontron/mal10...
PS8, Line 161: #if 0
: PAD_CFG_NF_IOSSTATE(GPIO_196, NATIVE, DEEP, NF1, MASK), /* PNL1_VDDEN */
: PAD_CFG_NF_IOSSTATE(GPIO_197, NATIVE, DEEP, NF1, MASK), /* PNL1_BKLTEN */
: PAD_CFG_NF_IOSSTATE(GPIO_198, NATIVE, DEEP, NF1, MASK), /* PNL1_BKLTCTL */
why dead code?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39133
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8432e10396f77eb05a71af1ccaaa4437a2e43ea
Gerrit-Change-Number: 39133
Gerrit-PatchSet: 8
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Lance Zhao
lance.zhao@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Andrey Petrov
anpetrov@fb.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 03 Mar 2020 06:41:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment