Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35626 )
Change subject: superio: add support for IT8380 ......................................................................
Patch Set 2:
(2 comments)
rest looks good to me as far as i can say without having the datasheet
https://review.coreboot.org/c/coreboot/+/35626/2/Documentation/superio/ite/i... File Documentation/superio/ite/it8380.md:
https://review.coreboot.org/c/coreboot/+/35626/2/Documentation/superio/ite/i... PS2, Line 49: Planform Platform
https://review.coreboot.org/c/coreboot/+/35626/2/src/superio/ite/Makefile.in... File src/superio/ite/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/35626/2/src/superio/ite/Makefile.in... PS2, Line 36: subdirs-y += it8380 please put this at the beginning of this block, so that the list is sorted
-
Felix Held (Code Review)