Change in coreboot[master]: mb/prodrive/hermes: Configure ALC888 Port B Vref - coreboot-gerrit

25 Nov 2021


      Attention is currently required from: Christian Walter, Angel Pons, Arthur Heymans.
Justin van Son has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58879 )
Change subject: mb/prodrive/hermes: Configure ALC888 Port B Vref
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/prodrive/hermes/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/58879/comment/8b7adeac_e7d2ee70 
PS2, Line 145: 0x12
...
To check: Datasheet says port B uses NID 0x18.
A custom realtek driver is used here, NID 12 is (ab)used by the driver to set VREF for NID 0x18, since the driver resets the codec when it starts, and the VREF registers for the ports themselves are volatile.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/58879
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iaa11ba9c74f643e94046d4983fbce65dbedd1025
Gerrit-Change-Number: 58879
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Justin van Son justin.van.son@prodrive-technologies.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Thu, 25 Nov 2021 13:35:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment