Attention is currently required from: Intel coreboot Reviewers, Jayvik Desai, Kapil Porwal, Pranava Y N, Ronak Kanabar, Subrata Banik.
Jérémy Compostella has posted comments on this change by Ronak Kanabar. ( https://review.coreboot.org/c/coreboot/+/86301?usp=email )
Change subject: soc/intel/pantherlake: Add support for VMD device
......................................................................
Patch Set 3:
(2 comments)
File src/soc/intel/pantherlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/86301/comment/99629328_c49cf521?usp... :
PS3, Line 564: const struct soc_intel_pantherlake_config *config)
The indentation does not comply with the rest of the file.
https://review.coreboot.org/c/coreboot/+/86301/comment/0998d18c_f75ec4d9?usp... :
PS3, Line 566: /* VMD */
This comment does not serve any purpose.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86301?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie391196e7b4537d1146ac30177a0ba472a1bfb43
Gerrit-Change-Number: 86301
Gerrit-PatchSet: 3
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Pranava Y N
pranavayn@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Attention: Pranava Y N
pranavayn@google.com
Gerrit-Comment-Date: Fri, 14 Feb 2025 18:56:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No