Attention is currently required from: Tim Wawrzynczak, Subrata Banik, Aamir Bohra, Andrey Petrov, Patrick Rudolph.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51085 )
Change subject: driver/intel/fsp2_0: Allow function to run serially on all APs
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51085/comment/d58aebca_d057f080
PS2, Line 9: singlethread
The name seems to be `run_serial`.
https://review.coreboot.org/c/coreboot/+/51085/comment/d28c5e6b_84a72c2b
PS2, Line 14:
Please give some numbers, on how much time this actually saves. Concurrency can (and often does) add a lot of hard-to-debug problems.
It might be a good idea to add a commit before, adding timestamps for this port or printing the execution time using the stopwatch framework.
File src/drivers/intel/fsp2_0/ppi/mp_service_ppi.c:
https://review.coreboot.org/c/coreboot/+/51085/comment/55735591_6768a9d6
PS2, Line 67: run_serial
I’d prefer the opposite name `run_in_parallel`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51085
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4d85dd2ce9115f0186790c62c8dcc75f12412e92
Gerrit-Change-Number: 51085
Gerrit-PatchSet: 2
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Fri, 26 Feb 2021 08:12:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment