Attention is currently required from: Subrata Banik, Paul Menzel, Tim Wawrzynczak, Stefan Reinauer, Angel Pons. Hello build bot (Jenkins), Tim Wawrzynczak, Tim Wawrzynczak, Stefan Reinauer, Angel Pons, Angel Pons,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/54305
to look at the new patch set (#7).
Change subject: util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset ......................................................................
util/ifdtool: Use -p platform name to detect IFDv2 platform and chipset
ifdtool uses `chipset` information to determine how certain straps are decoded. This has been used for IFDv1 platforms as well as IFDv2 platforms (CHIPSET_500_600_SERIES_TIGER_ALDER_POINT).
IFDv2 platforms are all expected to pass in `-p` argument to identify the platform. This platform information can be used to identify the appropriate chipset information. For IFDv1 since `-p` argument is not provided, ifdtool needs to use certain fields in the descriptor (e.g. strap length) for unique identification of IFDv1 chipset.
This change updates `check_ifd_version()` function to: 1. Determine if IFD version is v1 or v2 based on `-p` argument. If `-p` is not provided, it assumes that the platform is using IFDv1. 2. Based on IFD version, it calls either `ifd2_platform_to_chipset()` or `ifd1_guess_chipset()` to determine chipset information.
This fixes the issue reported with CB:44815, where ifdtool is unable to identify Alder Lake chipsets.
BUG=b:153888802 TEST=Able to dump FD contains correctly with platform quirks on Brya Platform.
ifdtool -d coreboot.rom -p adl
PCH Revision: 500 series Tiger Point/ 600 series Alder Point
Change-Id: I25f69ce775454409974056d8326c02e29038ec8a Signed-off-by: Subrata Banik subrata.banik@intel.com --- M util/ifdtool/ifdtool.c M util/ifdtool/ifdtool.h 2 files changed, 39 insertions(+), 71 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/05/54305/7