Subrata Banik has submitted this change. ( https://review.coreboot.org/c/coreboot/+/87109?usp=email )
(
1 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: soc/intel/pantherlake: Directly assign HDA SDI enable ......................................................................
soc/intel/pantherlake: Directly assign HDA SDI enable
The double negation (`!!`) was unnecessarily used when assigning the `pch_hda_sdi_enable` type boolean from the SOC config to the FSP M config.
This commit removes the redundant `!!` operator, directly assigning the boolean value of `config->pch_hda_sdi_enable[i]` to `m_cfg->PchHdaSdiEnable[i]`.
TEST=Able to build and boot google/fatcat.
Change-Id: I9233116ca2bfaeac2f685d464a1cb261f067db6a Signed-off-by: Subrata Banik subratabanik@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/87109 Reviewed-by: Wonkyu Kim wonkyu.kim@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Kapil Porwal kapilporwal@google.com Reviewed-by: Jérémy Compostella jeremy.compostella@intel.com --- M src/soc/intel/pantherlake/romstage/fsp_params.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: Wonkyu Kim: Looks good to me, approved build bot (Jenkins): Verified Jérémy Compostella: Looks good to me, approved Kapil Porwal: Looks good to me, approved
diff --git a/src/soc/intel/pantherlake/romstage/fsp_params.c b/src/soc/intel/pantherlake/romstage/fsp_params.c index b5fc93b..521d2f2 100644 --- a/src/soc/intel/pantherlake/romstage/fsp_params.c +++ b/src/soc/intel/pantherlake/romstage/fsp_params.c @@ -162,7 +162,7 @@ m_cfg->PchHdaIDispCodecDisconnect = !config->pch_hda_idisp_codec_enable;
for (int i = 0; i < MAX_HD_AUDIO_SDI_LINKS; i++) - m_cfg->PchHdaSdiEnable[i] = !!config->pch_hda_sdi_enable[i]; + m_cfg->PchHdaSdiEnable[i] = config->pch_hda_sdi_enable[i];
/* * All the PchHdaAudioLink{Hda|Dmic|Ssp|Sndw}Enable UPDs are used by FSP