Attention is currently required from: Subrata Banik.
Appukuttan V K has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82699?usp=email )
Change subject: soc/intel/meteorlake: Exclude deprecated upd from FSP2.4 builds ......................................................................
Patch Set 3:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82699/comment/ef46c1c1_90885887?usp... : PS3, Line 9: EnableMultiPhaseSiliconInit upd is deprecated and has been : removed starting with v2.4 of FSP specification.
are you saying `EnableMultiPhaseSiliconInit` UPD has deprecated because it has been set to 1? (w/ FS […]
It is removed from header and FSP is not depending on this UPD to enable it with 2.4.
#736809 sec 6.1.3
This value is deprecated and has been removed starting with v2.4 of this specification. Multi-phase silicon initialization is mandatory for all FSP implementations compliant to v2.4 of this specification, see Section 9.11 for further details.
For FSP implementations compliant to v2.2 through v2.3 of this specification, an FSP binary may optionally implement multi-phase silicon initialization, see Section 9.11 for further details. This is only supported if the FspMultiPhaseSiInitEntryOffset field in FSP_INFO_HEADER is non-zero, see Section 5.1.1 for further details
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/82699/comment/53b9ecb6_0da0ca70?usp... : PS3, Line 80: #if (CONFIG(FSPS_HAS_ARCH_UPD) && !CONFIG(PLATFORM_USES_FSP2_4))
why are we disabling `EnableMultiPhaseSiliconInit` for FSP 2.4 specification? […]
UPD is removed and it is not configurable in Fsp2.4. It is mandatory to support. Guarded to avoid build issues with FSP2.3 x32 builds.