[XL] Change in coreboot[main]: soc/mediatek/mt8196: Add RTC driver

[Paul Menzel (Code Review)]

Attention is currently required from: Hung-Te Lin, Jarried Lin, Yidi Lin, Yu-Ping Wu.

Paul Menzel has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85978?usp=email )

Change subject: soc/mediatek/mt8196: Add RTC driver
......................................................................

Patch Set 1:

(5 comments)

File src/soc/mediatek/common/rtc_osc_init.c:

https://review.coreboot.org/c/coreboot/+/85978/comment/4a50d7b2_c396cfad?usp... :
PS1, Line 7: u16
Why limit the length?

File src/soc/mediatek/mt8196/include/soc/rtc.h:

https://review.coreboot.org/c/coreboot/+/85978/comment/13b2c8c1_e9fd6690?usp... :
PS1, Line 68: //void rtc_boot(void);
Remove?

File src/soc/mediatek/mt8196/mt6685_rtc.c:

https://review.coreboot.org/c/coreboot/+/85978/comment/40bf9107_0a95d1d1?usp... :
PS1, Line 167: 	printk(BIOS_INFO, "EOSC cali val = %#x\n", val);
Sounds more like a debug message?

https://review.coreboot.org/c/coreboot/+/85978/comment/19739ab7_bb2327db?usp... :
PS1, Line 221: 	printk(BIOS_INFO, "%s time out!\n", __func__);
Is this an error?

https://review.coreboot.org/c/coreboot/+/85978/comment/a06be23a_9db2c010?usp... :
PS1, Line 497: void rtc_boot(void)
It looks like it’s used in other drivers too, but I find the name non-descriptive.